cd-bitwarden

Results 13 comments of cd-bitwarden

> Should I just put notes above the code that needs to be moved, so that it can be moved by the person working on web/app/browser etc?

This was merged in a different PR

> Looks good, thanks for the updates @cd-bitwarden! The only other thing we might want to consider adding is tests for the new route guard? Just an idea, I think...

> > > Looks good, thanks for the updates @cd-bitwarden! The only other thing we might want to consider adding is tests for the new route guard? Just an idea,...

> > Good eye! It wouldn't be a bad idea to do so, however, is it overkill? I'm not super versed on testing so I couldn't say - but to...

This has been addressed with #4057

> Just a few things to take a look at. > > I would recommend fixing merge conflicts and getting the latest from the sm/secrets-feature branch because some repository code...

I plan on writing the tests after the initial PR review

@Thomas-Avery other than any changes you request to my most recent push, I just need a little help knowing which tests to add/remove/update :)

> I guess removing the defaults from the two urls would be the simplest solution. At the moment the script just checks for the base_url to exist as a workaround...