server icon indicating copy to clipboard operation
server copied to clipboard

Sm 2 organization

Open cd-bitwarden opened this issue 3 years ago • 1 comments

Type of change

- [ ] Bug fix
- [ x ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Goal: Create OrganizationPasswordManager OPM and OrganizationSecretsManager OSM , and move OPM columns from the Organization table into the OPM table. -- This PR is for the initial DB changes, a second PR will be created with the future migration.

Code changes

Added the following new stored procedures: OrganizationPasswordManager
OrganizationSecretsManger OrganizationPasswordManager_Update OrganizationSecretsManager_Update OrganizationSecretManager_Create OrganizationPasswordManager_Create

Altered the following sprocs

Organization_DeleteById Description of changes: Search for OrganizationPasswordManager and OrganizationSecretsManager records and delete them if they exist.

Organization_ReadAbilities Description of changes: During the transition stages of Organization_ReadAbilities, it needs to look at the OPM table now to get the UsersGetPremium column back.

Organization_UpdateStorage Change Description: [Storage] is now stored on the OPM table, this proc needs to be updated to store it there now instead of Org table, we should also change the name to OPM_UpdateStorage, also added RevisionDate to the OPM table.

Altered the following Views OrganizationView

Change Description: Update the OrganizationView to pull back from the OPM table the fields that are now being stored on OPM.

Queries

  • Query to allow nulls inside the Organization table.

Before you submit

- [ ] I have checked for formatting errors (`dotnet format --verify-no-changes`) (required)
- [ x ] If making database changes - I have also updated Entity Framework queries and/or migrations
- [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required)
- [ ] This change requires a **documentation update** (notify the documentation team)
- [ ] This change has particular **deployment requirements** (notify the DevOps team)

cd-bitwarden avatar Jul 11 '22 20:07 cd-bitwarden

I took a quick look but it's typically difficult to review migrations scripts directly without the Sql/dbo files.

Hinton avatar Jul 12 '22 07:07 Hinton

This was merged in a different PR

cd-bitwarden avatar Mar 01 '23 21:03 cd-bitwarden