Caleb Cartwright

Results 668 comments of Caleb Cartwright

Want to reiterate that the suggestion to let macro authors define their own formatting asked in https://github.com/rust-lang/rustfmt/issues/8#issuecomment-2197671615 and alluded to again in the IRLO thread noted https://github.com/rust-lang/rustfmt/issues/8#issuecomment-2334077035 has been suggested...

My only concern with a broad brush approach here would be modifying rustfmt behavior in a manner that fails to adhere to the style guide. Would want some clarity on...

@HarrisonHemstreet - this is another one that could be interesting for you to look at. At the end of the day, we've got a bad invariant where we've got an...

Acknowledge seeing this and share the initial reaction of puzzlement. Obviously any changes here, bug fix or otherwise, can have a wide blast radius of formatting changes, so we'll need...

@joshtriplett - to be clear, I have not said nor am I implying that we do nothing. It deserves consideration and careful inspection, both to determine/confirm there's divergence from prescribed...

I'm marking this as a p-high, as I'd really like to get `imports_granularity` stabilized, with at least a few of the variants stabilized (IIRC one or two may not be...

I'm going to close because from the rustfmt team perspective this is now resolved with https://github.com/rust-lang/rustfmt/pull/6284 completed The original topic here was a report about compatibility with the sorting algorithm...

Going to close, please feel free to follow up if necessary

Thanks for sharing. The issue title refers to deleting items, but the snippets and description refer to commenting things out. Are you able to reproduce the described behavior when deleting...

Thanks for sharing. Few cursory questions: * What version of Windows are you running? * Are you launching VS Code from a traditional Windows context (e.g. Command Prompt, Explorer, etc.),...