Caleb Cartwright

Results 668 comments of Caleb Cartwright

> What's the status of this tool? To be honest, I'm not sure. I believe it's complete in terms of the original scope when it was added but it's not...

The conversation on #1324 may be of interest for this thread

There's also [cargo scout](https://github.com/o0Ignition0o/cargo-scout) that may be worth checking out as well

The process for stabilizing options is defined in https://github.com/rust-lang/rustfmt/blob/master/Processes.md @scampi & @topecongiro - correct me if I'm wrong but my understanding is that the current focus is on rustfmt 2.0,...

> Would it be plausible to split this into wrap_comments and wrap_doc_comments, and make wrap_doc_comments markdown aware? Could you elaborate a bit on the motivation? Is it just about wanting...

> It looks like this was fixed at some point in the past, then we regressed. That is incorrect. There are different branches in this repository with what at this...

Overall lgtm, my impression is that there's only a couple outstanding nits so this is definitely a change we can and will make for 2024. From a sequencing pov, I'd...

> Would it be possible to like annotate the macro like Suppose it could be possible for those defined within the project being formatted, but practicality would be questionable since...

@GilShoshan94 that suggestion was previously made above, and the challenges/rationale against has similarly already been shared

Contextual reminder: rustfmt operates on the AST, and does not directly work with input files. For macro calls, rustfmt doesn't really directly process the arg tokensteams either; it chucks the...