Caleb Cartwright

@ytmimi do you think this would be better to merge before or after the next sync? (no promises but I'm going to try to do one today)

https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=1b08120b0a4c44013840a6cbd24e9fa2 ```rust fn main() { match x { ArgValue::Lit(other) => { // FIXME: add a ui test for this return Err(syn::Error::new( other.span(), "expected boolean, path, or string literal", )) }...

will add explicitly, and more verbosely, that I'd prefer to see the default for this option be the same value as max_width as well. AFACIT the default value of 80...

> Would it be possible to default to whatever max_width is, instead of having a fixed default value? Yes, there's a number of width related options implemented this way >...

> What's the current default value when I run cargo fmt on stable? The current default is 80 https://rust-lang.github.io/rustfmt/?version=v1.6.0&search=#comment_width However, rustfmt doesn't format comments on stable, so this option isn't...

@ytmimi I want to highlight this one for discussion and review as I wonder if this may be related to the v2/2024 behavior that avoids trailing comment alignment and I...

> I know this looks like a massive addition, and it is, but 21k+ lines are related to JSON files and test cases that get autogenerated from those files if...

with the caveat that there be may be some nuance i'm unaware of (as i've not looked closely at `comrak`).. i'm generally highly disinclined to delegate any aspect of formatting...

First, I really want to emphasize my appreciation for bringing this forward into an issue for focused discussion, and offering to work on it on top of that! I confess...

> rustfmt versions: > > * rustfmt 1.4.15-stable ([530eadf](https://github.com/rust-lang/rustfmt/commit/530eadf4b42ddf35b209d4f4acd120f3fcc467ce) 2020-06-02) > > * rustfmt 1.4.15-nightly ([aedff61](https://github.com/rust-lang/rustfmt/commit/aedff61f7ac4fc2b287ff76d33f2584e1f63a3af) 2020-05-19) Could you try with a more recent version? There were a lot of...