Jean Boussier

Results 329 comments of Jean Boussier

> this timeout and why it isn't strictly necessary anymore. Yes. We recently removed all usage of it. So it's fine. We'll have to do a major version bump though....

I tested this branch with shopify in dev and test. Seems all green. We can try it out on production servers once the last concerns are settled.

> Using ftok requires that we have a file on disk per resource that is visible to all workers. This (unless I'm missing something) is I'm afraid impossible for us...

I think you are going to far guys. We're talking about hashing human identifiers. Even MD5 would do. The risk of accidental collisions is extremely low.

@Sirupsen because then you can't run your integration tests on OSX. :sad_panda:

Oh. Well, if we end up having an in-memory semaphore, then yes.

I'd add another comment but more general: Please avoid abbreviations, like `cb`, just use `circuit_breaker` instead.

> after switching to Thread base web server like Puma That's not going to happen for various reasons. And even if we did, we'd at best run two threads per...

> Can you check what I wrote? I did when I added Early Hints support to Unicorn. Quick answer because I'm on mobile, I can elaborate more tomorrow if needed....

> we should not make an API which is tied to the format of the HTTP/1 headers. It seems like we are in agreement here? I still don’t understand what...