Jean Boussier

Results 329 comments of Jean Boussier

It's a bit complicated to add another gem version to the "matrix", we test multiple Ruby versions, but not multiple dependency versions. I'd encourage you to first open a PR...

Note to self: CI is failing because `bundle lock` has to be run. (I'll probably do it tomorrow)

I think we should benchmark to see what the impact is. I'm not too worried about the hash lookup, a bit more about the `self.class.attribute_aliases` part. If the impact is...

This is a nice find, and I agree it should be fixed. However I don't think adding this extra feature to `class_attributes` is the way to go. Its semantic is...

So your strace suggest that it's the cache for `/srv/www/ops-lib/ops-cli2.rb` that somehow end up huge. Couple questions: - How big is `/srv/www/ops-lib/tmp/cache/bootsnap/compile-cache/b6/5cc8804abfcc92` ? - How big is `RubyVM::InstructionSequence.compile_file("/srv/www/ops-lib/ops-cli2.rb").to_binary.bytesize` ?

Hum, that's really a weird one. So based on what you say about touching the file, when you do this you actually bypass the cache for that one file. It's...

Wow, that's extremely weird, I really don't get what might be happening here :/

I'd be happy to review a Dalli adapter. Looking at Dalli's source it has like most clients a nice chokepoint for Semian to integrate itself: https://github.com/petergoldstein/dalli/blob/65a5a8cbf4b6993d298eb9fab8bbd0884c673bef/lib/dalli/client.rb#L353-L369 So it shouldn't be...