Jean Boussier

Results 329 comments of Jean Boussier

I'd like to wait a bit to see if it's really causing confusion. I wouldn't be against a "deprecated" section in the readme, or better in a `deprecations.md`, but I'd...

I fixed the typo, and refactored `ProtocolError` so I can reuse it. I honestly think the `pop` is simpler and better than the copy. I mean I get your point...

We no longer need this because pipelines are serialized eagerly.

`scheme` is no longer a thing in 5.0, closing.

> Why not drop Redis 5? The problem isn't so much Redis 5, but RESP2. Some people migrated to Redis 6 or 7, but used proxies such as https://github.com/envoyproxy/envoy/issues/17571 which...

Aaaand it's green! Further work will happen on master.

> If this is a good approach, the hashing algorithm probably can be changed. But this will also lead to a lot of cache misses when deployed for the first...

Ok, so there's no standard to adhere to. So we can probably change it in a major without any issue.

@fatkodima I'd go with MD5 for everything as it's likely the best perf / distribution ration available in the stdlib. We should probably make that configurable though. e.g. accept a...

Closing since it's somewhat expected with the default `reconnect_attemps: 1`. I'm not a huge fan of this default, and I may change in in 5.0 (not sure) but in the...