Jean Boussier comments

Results 329 comments of


                                            Jean Boussier

Feature request: When throwing a Timeout:Error, print the query too

I don't think that's necessary.

SystemStackError (stack level too deep) on redis-rb 4.6.0

Hum, would you have a more complete backtrace? Because I can't tell where it's recursing from this one.

Fix reutrning in subscription callbacks cause race condition

Could you produce a test case for this? It's really a fairly sensitive thing, so I'm not really willing to change this without proper test coverage on it.

subscribe_with_timeout taking longer than expected to timeout

This is solved in 5.0.

Add the :nearest_slave role for Sentinel mode

Rubocop has a few complaints. The code looks sane to me, but @supercaracal if you have time and are willing to give this a second look, it would be much...

Segmentation Fault issue

I might be wrong, but I'm 99% sure this is a common OSX bug that has been plaguing all Ruby versions since months: https://bugs.ruby-lang.org/issues/15490

Allow sentinel configuration to accept String URIs and not just a Hash

fixed in #599

Allow sentinel configuration to accept String URIs and not just a Hash

Nevermind, I misread.

Allow sentinel configuration to accept String URIs and not just a Hash

That's is solved in 5.0

IOError: closed stream (JRuby 9.2.7)

Did you try against different servers? I'm asking this because the exception suggest the connection was closed by the server. It could be a configuration issue with your server, or...