Jean Boussier

Results 329 comments of Jean Boussier

The entire network code was replaced, so I think we can close this unless someone can reproduce in 5.0.

Closing as stale since all this code was just replaced for the upcoming 5.0.

Could you provide some context? A repro script would be ideal, but at the very least a non truncated backtrace, and the command and parameters?

Closing as non actionable

Can you benchmark a little higher on the stack? Yes MD5 is much slower than CRC32, but does that have visible impact on a full cache read? Another thing I'd...

> `SecureRandom.hex` I don't want to be too picky, but what about the same test but with somewhat similarish keys, e.g: `"user:#{numeric_id}"`?

This is fixed on master (upcoming 5.0). If either `host`, `port` or `path` is passed `$REDIS_URL` is ignored.

The CI failure is legit, you have a syntax error. As for the API, I'm not a fan of these keyword being used for two different things based on the...

> Also, can you please tell me how I should test this code locally? You can run `make` then `make test`.

This should be solved in 5.0 (to be released soon). `redis-client` assumes UTF-8 first, but check for validity, and return `Encoding::BINARY` strings otherwise.