Armağan

I believe this issue requires a breaking change please see https://github.com/primer/react/pull/3634#pullrequestreview-1647835818 and https://github.com/primer/react/pull/3634#issuecomment-1739930260

I think we should re-open this because the button loading state PR was reverted and it is being re-introduced here https://github.com/primer/react/pull/4485 (It is referenced in https://github.com/primer/react/pull/4426 )

@mperrotti I'm assigning this issue to you since you have done the work already in https://github.com/primer/react/pull/4485 but feel free to un-assign yourself if there is anything I misunderstand here.

Hello 👋 Sorry for the late reply! Love what @siddharthkp suggested ✨ and glad to hear that it is working for your case @marywhite. >If this is a repeatable pattern...

>how do I run the integration tests in dotcom? @mperrotti Here : https://github.com/github/primer-engineering/blob/main/how-we-work/testing-primer-react-pr-at-dotcom.md 😊 We also linked this in the PR template. It just makes sure that the primer/react PR...

Hi folks 👋 @maximedegreve @siddharthkp Regarding the early truncation, it was an accessibility improvement that we made sure there is at least two elements in the overflow menu if we...

>I think it's always a risk when we bake in some padding around the edges of the component. I don't think we should add a prop to remove noPadding. the...

I did a quick lookup on the current use cases of UnderlineNav to see how many of the cases reset the padding and there are only few of them. https://musical-adventure-wlr3n3k.pages.github.io/?name=%22UnderlineNav%22&attribute=sx...

I am taking this to work in progress and remove from the inbox since we are having the conversation 🙌

I updated the title to reflect the paddings discussions we are having since the originally reported issue is an accessibility criteria. @maximedegreve let me know if there is anything I...