Armağan
Armağan
@lesliecdubs all my WIP is in the review process so I am picking this up 😊
@khiga8 I had a look at how we generate the slugs in doctocat. The `github-slugger` library that we use is actually doing what you were describing however the issue in...
@khiga8 I am sorry that I didn't respond to your post - I had other things come to my way and didn't have a chance to look into this issue...
> > Should we add an e2e test for the focus state? > > @broccolinisoup done in [8756ea4](https://github.com/primer/react/pull/5140/commits/8756ea40d7a966eb96d3aa54a1ec9c4db67b2cab), [5736299](https://github.com/primer/react/pull/5140/commits/57362998d0b27cbf1d5d5f2382f204c5b15f87f5). LMK if I did that right 😅 Yeah perfect! 🔥 Side...
>what would be "standard" to just do it on the default for button/iconButton? Yeah that makes sense to me!
Hello! @mperrotti suggested that we can wrap the content as we do in PVC. Since this is a rare case, we are okay with that. @khiga8 Feel free to push...
> @broccolinisoup my understanding since we're keeping the combobox-related functionality is that it _should_ mostly be the same behavior, if I remember right 👀 Oh this is great! Thanks for...
Hello @cihad 👋 Thanks for raising this issue. We think it makes sense and will give it a try. Feel free to push a PR if you would like, otherwise...
@mperrotti @joshblack Sorry, this is my ignorance 😬 I didn't even think of checking back - I just assumed that will work. Let me try upgrading primer/react - I know...
@mperrotti That sounds good to me! I added the label! Although this PR is blocked itself but it is not blocking [v36 PR I mentioned in the description](https://github.com/primer/react/pull/3260) anymore -...