Armağan

Results 101 comments of Armağan

@joshblack I was testing https://github.com/primer/react/pull/4235, it cancels the deploy preview (fork) action in this PR. Do you happen to know why that is failing to run? Also what is the...

>It sounds like a great idea to let the release coordinator know what to fix, but I'm not sure what you mean. Where should the commit ID go? @camertron commit...

Hello @TylerDixon / @jonrohan 👋🏻 The recommended versions of the flat and mocka packages are a few major versions higher and I don't have much context on this component. Would...

Hello @camchenry 👋 Thank you so much for writing this up! We appreciate you taking the time and gave thorough thoughts. I believe [the new Tooltip](https://primer.style/react/drafts/Tooltip) should fix this issue...

Thanks @iansan5653 for raising this issue. I liked it to the [epic (Staff only link)](https://github.com/github/primer/issues/2531) that we do all the dialog work. Let us know if you have any concern...

> I couldn't reproduce the tiny layout shift of UnderlineNav.Item's counters and icons in a real browser, so I updated `UnderlineNav` snapshots. If anybody can reproduce, I can make more...

Thanks @JelloBagel for filing this issue. We agree it is better to fix it and It is in our backlog now.

> Sorry for the delay @broccolinisoup! Left a couple of comments/notes, also had a question around alignment, should the underline nav align here? > > ![image](https://user-images.githubusercontent.com/3901764/204888056-f1d07524-c587-47e6-8c35-ce116fcd9f63.png) The spacing is still...

Keeping this issue open until we release the remediations in [the next major release](https://github.com/github/primer/issues/1294)

@siddharthkp is this issue still relevant to the select panel work or not so much anymore?