Ben Sheldon [he/him]

Results 285 comments of Ben Sheldon [he/him]

@mollerhoj thanks for asking! There is not currently built-in batching functionality in GoodJob. Can you give some examples of how you're using batching? It's likely possible to orchestrate it outside...

That's helpful. I'm wondering if this sort of interface would be sufficient? ```ruby class FanOutJob < ApplicationJob include GoodJob::ActiveJobExtensions::Batch after_batch do |id:, key:| id # => a UUID; all the...

@mollerhoj Thanks for collaborating on this! I am excited to get something working here. There's a lot of stuff to cover, so I want to focus on what would make...

@mollerhoj Thanks for sharing those resources. I, unfortunately, am not available to do speculative interface building; GoodJob already has quite a roadmap. I also don't want to waste your time...

@mollerhoj Thanks! Just want to keep things moving forward. I put together a proof-of-concept for an interface. Please let me know what you think. The code is also fully runnable...

I updated the gist: https://gist.github.com/bensheldon/5d3add207b7c5e689682c29ebbc506ab#file-batch_jobs-rb-L98-L102 > (a) The ability to have more than one param per job. I updated the example to show this is possible. > (b) The ability...

@mollerhoj I'm revisiting this to do some more scoping before I start development. I was looking over the [Sidekiq Batch API Documentation](https://github.com/mperham/sidekiq/wiki/Batches). I'm curious, with this example, where you define...

Yep, where the file/class/directory lives. The thing I'm still working out, and trying to become comfortable with, is where the callback/success code lives. It has to be somewhere static/committed.

@mollerhoj thanks for sharing that! It looks like Laravel serializes the callback closures into the database, and then executes them later. I don't think Ruby has a safe equivalent of...

I have an implementation of Batches I would like feedback on. The full PR is in #712. Here is a link to the proposed Readme documentation: https://github.com/bensheldon/good_job/blob/batches_tdd/README.md#batches