Ben Sheldon [he/him]

Results 285 comments of Ben Sheldon [he/him]

Closing this because of inactivity. Please comment if you are still seeing this.

oooooh! @adenta thanks for sharing that! I'll try to reproduce that case and see if I can fix it 🙌🏻

@adenta Does this describe what you discovered in your codebase? > There was an `include Rails.application.routes.url_helpers` at the start of a file for a [model] instead of being inside the...

@julik thanks for opening the issue! I watched the youtube video and I think it makes sense to me. - I'm open to this, though I think I'd want to...

@mitchellhenke thanks for digging into this! It's complicated 😄 First, do you _need_ to be using concurrency controls with `total_limit: 1`? There was a point in GoodJob's history where apps...

@mitchellhenke ah nuts! bummer 😞 > Is it possible to evaluate the locking mechanism around cron jobs? I'm open to doing this: moving the lock out of Postgres and into...

> This makes the issue seem like a race condition between scheduling and execution--at least when not preserving records. I think the "when not preserving records" is maybe the core...

It was really simple to not delete records that are inserted by cron: https://github.com/bensheldon/good_job/pull/767 Turns out that the job preservation and the automatic job destruction... are all entirely independent of...

@mitchellhenke it's ok to continue the conversation here 😄 That makes sense that Listen/Notify could get noisy when enqueuing a lot of jobs. No objection to having the ability to...

@mitchellhenke fyi, I'm planning to release both #810 and #814 together because I think both pieces of functionality are useful (global and granular). I'm currently struggling with some flaky CI...