Ben Sheldon [he/him]

Results 285 comments of Ben Sheldon [he/him]

So just poking at it a bit, it seems like defining `method_missing` prevents mimic from raising NoMethod exceptions entirely. Here's the changes I made to the existing spec suite: https://github.com/bensheldon/naught/commit/4587e35ce60543c509a89fdc164007fddef2d3ab...

@rosa awesome! thank you for picking it up 🙇🏻

I force-pushed over the change, but `task.cancel if task` required being called outside of synchronization and thus has the same danger of unsynchronized read/write. In consultation with @matthewd, I I'm...

I think the correct way to have no queue (e.g. run the fallback if all threads are active) is to use `max_queue: 0, synchronous: true`: ```ruby Concurrent::ThreadPoolExecutor.new(max_queue: 0, synchronous: true)`...

@banzhihang1 can you share the implementation of `ClassFactory.create_dynamic_model`? I'm imagining that its likely to be the problem here (i.e. not thread safe). It would be most helpful if you can...

I appreciate that feedback! Here's what "Polished Ruby Programming" says about it: > RuboCop implements many checks, called cops, and most of the cops are enabled by default, even those...

The other learning I should describe from `rubocop-gitHub` was that we had 3 different needs that we needed to detangle: - Recommended cop rules (enabled/disabled/options) - Our own custom cop...

I added some more detail in https://github.com/rails/rubocop-rails-omakase/issues/14. My recommendation would be to remove `DisabledByDefault: true` and instead maintain these explicit enables/disables.

@gap777 sorry, I missed the reply. Can you share the code (both your job and the calling code) that you're using?

My experience with Open311 and not having a validator and reference implementation to go along with the spec has led to lots of heartbreak and frustration. So +1 on sharing!