Ben Sheldon [he/him]

Results 285 comments of Ben Sheldon [he/him]

@vtamara I think we're in agreement: in all environments `config.relative_url_root = "/foo/bar` _should_ also serve assets from `/foo/bar/[path-from-public/]`. I'll take a look at what's happening there.

I'm familiar with this. This happens because anytime a Executor/Reloader context closes, it resets the CurrentAttributes: https://github.com/rails/rails/blob/5a92880f29226200019406a4369cce3668083b2a/activesupport/lib/active_support/railtie.rb#L48-L50 ActiveJob wraps every job execution with an Reloader: https://github.com/rails/rails/blob/5a92880f29226200019406a4369cce3668083b2a/activejob/lib/active_job/railtie.rb#L63-L71 btw, the change in...

hey @vtamara 👋🏻 I remember responding to you over in #49688. In [my PR](https://github.com/rails/rails/pull/45719), I think this note under "Other Information" is very relevant: > The existing tests imply that...

Sorry to have missed a follow-up on #9688 😞 > Could you please tell me how to change in the test case the "test harness's Rack mount point for the...

I came to those via an unrelated issue, but I just wanted to share that this is the best way in Rails (that I'm aware of) to convert ENV strings...

I'm fairly certain all of the Active Job adapters that are bundled with Rails have this problem and have always had this problem since they were introduced. I'm the author...

I guess it's not much practical difference to do this: ```ruby before_fork { ::Process.warmup } ``` ...versus having in the Puma DSL something like this: ```ruby ruby_process_warmup ``` Probably the...

@joshkoenig I think we should have a discussion about to what extent terminus is a wrapper around the Platform (mostly REST) API, and to what extent Terminus is implementing new...

@philipjohn just to quickly unblock you, I think the pipe character in that script is executed on the _remote_ rather than piping the output from the command to a local...