Ben Sheldon [he/him]
Ben Sheldon [he/him]
@pgvsalamander thank you for the proposal! I'll need to think about it a bit more. I want to throw out a thought seed: instead of moving towards more specific keys,...
Here's a simple/naive test case for Checkpoint 1: ```ruby # spec/lib/good_job/active_job_extensions/logging_spec.rb # frozen_string_literal: true require 'rails_helper' RSpec.describe GoodJob::ActiveJobExtensions::Logging do before do ActiveJob::Base.queue_adapter = GoodJob::Adapter.new(execution_mode: :external) stub_const 'TestJob', (Class.new(ActiveJob::Base) do include...
Yep. Dependabot has a package-ecosystem for GitHub Actions that will propose version bumps based on semantic versioning rules. It's very helpful. https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#inputs
I think bailing out if an existing PR is already open is good. If they're not being merged, then what's the point anyway. Dependabot does something similar, though it has...
fyi, these are the docs for the Save Page Now v2 API: https://docs.google.com/document/d/1Nsv52MvSjbLb2PCpHlat0gkzw0EvtSgpKHu4mk0MnrA/edit#heading=h.1gmodju1d6p0 My buddy did an example implementation in python here: https://github.com/palewire/savepagenow/pull/31
Tracking this down, it looks like the issue is that when agents disconnect, they are only removed from the list of agents (Agent.remove()), not unsubscribed from the channels. Thus when...
Thanks for the ping! Here's the PR that introduced that change: #45719 I'm not quite sure what the root cause is here, but to try to reduce the changes here...
@vtamara sorry, I think I'm confused now about the problem. The `relative_url_root` should prefix all paths with that value. This is the correct values I would expect that were fixed...
@nbennke The brief summary at this point, imo, is: you're using a workaround to a problem that no longer exists (albeit it existed for a very long time), and any...
@vtamara Thanks for sharing all of that! That's really interesting about the assets: > If you are using sprockets and you configured it to compile the resources at `public/mymount/point/assets` I...