Ben Sheldon [he/him]
Ben Sheldon [he/him]
Yes please to help. The Demo app (a full Rails app) lives in this same repository, in the `demo/` directory: https://github.com/bensheldon/good_job/tree/main/demo
> Am I correct in my read that the best way to get the backtrace right now is to set `on_thread_error` and report the error to Rails, which then would...
I noticed the Solid Queue is storing backtrace. I went to see how it stores the backtrace, and it stores the backtrace as an array in serialized JSON String: https://github.com/basecamp/solid_queue/blob/bf6bcf2b63a4f82164dd121a312c6eb3b576fda7/app/models/solid_queue/failed_execution.rb#L33
I'd be ok if someone wanted to add this to GoodJob. I think it should be a Postgres array of text, stored on the `good_job_executions` table (the DiscreteExecution model).
Thanks for considering working on this! Default. I think the column should live on the `GoodJob::DiscreteExecution` model / `good_job_executions` table. The code should check for the column existence before writing...
👍 Released! https://github.com/bensheldon/good_job/releases/tag/v3.28.0
This is tough because I think this is a problem with any library using abort_on_exception: it's doing exactly that. I can add an interrupt handler to GoodJob's main thread, but...
Oof, that monkeypatch :-) I don't think a gem should use abort_on_exception. If the subthread wants to raise on the calling thread, they should pass it into their sub-thread and...
Thanks for opening the issue! I wanted to unpack a few things for further exploration: 1. Fly is great! I'm really curious about how you have it configured for scaling,...
> I saw the loop in the CLI that should exit the application on sig TERM or INT or if GoodJob.shutdown is run. I'll start there to see why it...