Ben Sheldon [he/him]

Results 285 comments of Ben Sheldon [he/him]

I think this looks good so far. I think some Readme-driven-development might be in order here. What do you think about an interface like this: ```ruby my_job = MyJob.set(good_job_paused: true).perform_later(1234)...

These don't get distributed as options to a job, they are "properties" of the batch. So this won't work: `batch = GoodJob::Batch.new(good_job_paused: true)`

> Is the intent that setting those defaults occurs at higher levels and the enqueue methods should accept whatever is handed to them, or have I bumped into an edge...

fyi, I did some exploratory testing here: https://github.com/bensheldon/good_job/pull/1332 The takeaway is that this feature might have to hold until I get a major release for GoodJob done, because if someone...

Thanks for opening this issue. I think I like the general idea of it. Here's an idea that I think could accomplish this without hugely changing things: what if "pausing"...

Thinking about this some more, you can add jobs to a batch, and load the batch elsewhere, and the final callbacks won't be triggered until the batch is enqueued. Eg...

This is an Active Job thing: `ActiveJob::Base#initialize` should never have its method signature changed. I think you mean to customize the `#perform` signature to pass parameters to a job.

This sounds like it could be stored in `serialized_params` (arbitrary data that's stored at enqueue and only used during perform`). Here's an [example](https://github.com/bensheldon/good_job/discussions/901#discussioncomment-5394194) of serializing and deserializing attributes into that...

Let's enable query stats and add a job to clean them up. I copied this from another app: ```ruby # demo/app/jobs/pg_hero_capture_query_stats_job.rb # frozen_string_literal: true class PgHeroCaptureQueryStatsJob < ApplicationJob good_job_control_concurrency_with( key:...

Thank you!!! 🙇🏻 > I am assuming we can trigger the PgHero.capture_query_stats with GoodJob as well Yep, it's in the job example I copy pasted (in addition to the cleanup)