Tim Meusel

dear puppet, please do not autoclose PR that are only stale because nine of you reviewed it... @fraenki sadly this now needs a rebase, could you please do that?

@chelnak I did say as soon as the CI pass I can give it another review, but mostly this looks good already.

For me this also always fails with `fatal: ls-files -i must be used with either -o or -c` and an exitcode of 128. I think the command should be `git...

Thansk for the PR @olevole. Could you add the supported FreeBSD versions into the metadata.json?

@olevole can you take a look at the failing spec tests?

Hi @peterbeck, thanks for this issue. Can you provide a PR for this?

the parameter defaults to an ip address: https://github.com/voxpupuli/puppet-openvpn/blob/139c72778008b91469d445f4f2c89d5c35d57ef4/manifests/server.pp#L457 I assume your network interface has a different name? The default should probably be changed to `$facts['network']['ip']`

sorry, I made a typo, the correct fact is `$facts['networking']['ip']`. But this should work out of the box if your eth0 has an ip address, even with the current code.

I proposed https://github.com/voxpupuli/puppet-openvpn/pull/308 to make the setup a bit clearer.

@smortex looks like CentOS has some package conflicts. Is nodejs still supported there / did we setup the wrong repo / is epel broken maybe?