puppetlabs_spec_helper icon indicating copy to clipboard operation
puppetlabs_spec_helper copied to clipboard

Fix check:git_ignore rake task for git >= 2.32.0

Open ekohl opened this issue 3 years ago • 2 comments

WHen running tests I noticed this:

fatal: ls-files -i must be used with either -o or -c

However, rake proceeded so it wasn't failing.

This isn't a complete PR, but I wanted to at least make this obvious and so I wouldn't forget.

ekohl avatar Nov 11 '21 11:11 ekohl

For me this also always fails with fatal: ls-files -i must be used with either -o or -c and an exitcode of 128. I think the command should be git ls-files --ignored --exclude-standard --cached

bastelfreak avatar Dec 03 '21 14:12 bastelfreak

I included https://github.com/puppetlabs/puppetlabs_spec_helper/pull/351 now.

ekohl avatar Sep 13 '22 15:09 ekohl

Looking like this will go in rather than #351.

Again, will need rebasing as the changes come in.

chelnak avatar Oct 24 '22 10:10 chelnak

On a second look, this can actually go in now if you are happy @ekohl ?

chelnak avatar Oct 24 '22 10:10 chelnak

I did a trivial rebase and would be happy if this was merged & released.

ekohl avatar Oct 24 '22 10:10 ekohl