Andrew Sy Kim

Results 214 comments of Andrew Sy Kim

This is a warning printed by the Terraform provider whenever a service account resource is referenced https://github.com/hashicorp/terraform-provider-kubernetes/blob/main/kubernetes/resource_kubernetes_service_account_v1.go#L78 I'm not sure what we can do right now and I don't think...

Adding to this, the value of `TABLE_NAME` is still googlemaps_reviews_db, should be `netflix_reviews_db` or something similar

I believe @imreddy13 is working on this already https://github.com/GoogleCloudPlatform/ai-on-gke/pull/445

cc @umeshkumhar @imreddy13 @hsachdevah

Sorry for the delay on this patch! I plan to revisit https://github.com/ray-project/ray/pull/45498 this week

@kevin85421 the reason I didn't use suspend is that I don't think it will play nicely with Kueue because suspend means each retry goes to the back of the job...

Actually,I think I misunderstood what you said, we can use the same state machine logic for suspend without actually suspending the RayJob, will update the PR to do that. I'll...

@kevin85421 I incorporated your feedback, if the overall approach looks good to you I can polish the PR and add tests. So far I've manually verified this works: ``` $...

I think KubeRay has taken a general stance to avoid webhooks as many users mentioned that company policies forbid webhooks, but maybe this is worth revisitng? @kevin85421 would have more...