Andrew Sy Kim

Results 214 comments of Andrew Sy Kim

> can you also add a test? I tried to add a unit test but I couldn't get it passing because it didn't seem like the test actually reads images....

I've made the presubmits optional until we resolve the HF issue

I'm skipping the cloudbuild presubmit since we don't test kuberay TPU webhook there

All terraform solutions in `applications/*` are required to have e2e tests as part of presubmit check. See https://github.com/GoogleCloudPlatform/ai-on-gke/blob/main/cloudbuild.yaml for example e2e tests for `applications/ray`, `applications/jupyter` and `applications/rag`. Can you add...

I'm not sure why this was closed by the other PR since the flake is not related to stockouts. I also saw this again in https://github.com/GoogleCloudPlatform/ai-on-gke/pull/606

Might explain the flakes we're seeing when pulling Ray images: https://github.com/GoogleCloudPlatform/ai-on-gke/issues/520

I haven't seen this since merging https://github.com/GoogleCloudPlatform/ai-on-gke/pull/551 -- Should we close this @imreddy13 ?

Looks like we've been enabling this for GPU node pools already, but missed CPU node pools.

Might also explain flakes when pulling Ray images: https://github.com/GoogleCloudPlatform/ai-on-gke/issues/520