ai-on-gke icon indicating copy to clipboard operation
ai-on-gke copied to clipboard

Published 20 hours ago • verified publisher icon GoogleCloudPlatform

Update the README to reflect the correct sample dataset & surface this info earlier in the README

Open kumar-dhanagopal opened this issue 1 year ago • 2 comments

  1. Currently, https://github.com/GoogleCloudPlatform/ai-on-gke/blob/main/applications/rag/README.md mentions that the example uses https://www.kaggle.com/datasets/denizbilginn/google-maps-restaurant-reviews as the input dataset. However, per https://github.com/GoogleCloudPlatform/ai-on-gke/pull/385, the example uses a "Netflix shows" dataset.

  2. To help users quickly understand what the sample application does, consider mentioning the example dataset upfront in the introductory section of the README. Currently, the dataset info is buried rather deep in the README.

kumar-dhanagopal avatar Mar 25 '24 19:03 kumar-dhanagopal

Adding to this, the value of TABLE_NAME is still googlemaps_reviews_db, should be netflix_reviews_db or something similar

andrewsykim avatar Mar 26 '24 14:03 andrewsykim

I believe @imreddy13 is working on this already https://github.com/GoogleCloudPlatform/ai-on-gke/pull/445

andrewsykim avatar Mar 26 '24 14:03 andrewsykim