imsteev

Results 19 comments of imsteev
trafficstars

+1 to publishing a new release! this would support linting `.ts`, `.jsx`, `.tsx` files

I agree that `errorOnUnmatchedPattern` defaulted to false should work.. the only setting we've toggled is `reportWarnings` 🤔 the following is our exact setup: ``` name: 'eslint' on: [pull_request] jobs: eslint:...

@bradennapier are you able to take a look? this issue is coming up quite often for us during things like refactoring. the only workaround to remove the failing check is...

@bradennapier our config file looks like: ```js module.exports = { extends: [ 'react-app', 'prettier', 'plugin:@typescript-eslint/recommended' ], plugins: ['react-hooks', 'mocha', 'i18next', '@typescript-eslint'], ignorePatterns: ['build/**'], rules: { ... }, overrides: [ {...

> Also - what version of eslint are you using? Looks like the errorOnUmatchedPattern was added in 6.8.0 oh wait this might be it... we're on 6.7.2

@bradennapier alright bumping the version of ESLint to latest works for me (meaning the workflow passed with a deleted file!) the downside to this is that I have to add...

yeah any time i have to change a react-scripts dependencies, that `SKIP_PREFLIGHT_CHECK` flag is necessary. the workflow edit you mentioned seems promising, i didn't know you could add intermediate steps

@bradennapier thanks for this info. I think I have a solution that works, but it jumps through a lot of hoops just to get this Workflow to run. I wonder...

I agree, this should be implemented after #48 is done. Although `TarCheck` does check for extra files

I realized there's a lot of other keywords not implemented, so I thought it'd make more sense to discuss which unimplemented keywords need attention, rather than just pointing out one.