unimplemented keywords: 'flags' and 'nlink' (for tar archives)

[imsteev]

trafficstars

[schung@localhost Desktop] $ sudo `which gomtree` -f mount.mtree -p /mnt
2016/07/25 19:43:01 Unknown keyword "flags" for file "."

[vbatts]

why closed?

On Mon, Jul 25, 2016 at 10:27 PM, Stephen Chung [email protected] wrote:

Closed #40 https://github.com/vbatts/go-mtree/issues/40.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/vbatts/go-mtree/issues/40#event-734395287, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEF6bRDiaBb1RoU1JpX4Eum7E35lzFkks5qZXB5gaJpZM4JUp6x .

[imsteev]

I realized there's a lot of other keywords not implemented, so I thought it'd make more sense to discuss which unimplemented keywords need attention, rather than just pointing out one.

[imsteev]

I could re-open and edit this issue accordingly if you want

[imsteev]

With regard to "important" keywords, and to align with upstream mtree, 'flags' and 'nlink' (tar archive only) are keywords that should be looked at next.

[vbatts]

sure thing. It's a good thing to implement these keywords. Though having them be included in the default set may not be needed. Especially ones like nlink, as technology like ostree use hardlinks heavily, so the nlink on disk will almost always be different on anything given host.

[vbatts]

nlink is already implemented

[imsteev]

yeah but for tar archives we would have to manually keep track of links

[vbatts]

oh i see. yeah, keeping track of hardlinks in tar archives is more work

[imsteev]

nlink keyword implemented for tar archives, although nlink for directory Entry's have not been implemented.

[vbatts]

I've just stubbed flags, but we can hold on these still.