Madhur Jain

Results 45 comments of Madhur Jain

@shailpatels , what could I do to correct the checks.

> Is it possible to use the existing submitty duck image in `site/public/img` and the favicon already there? Is there something specific about the new ones checked in? They should...

I have removed the workbox components , they are not necessary as of now and could be added in the later pull requests.

> I tested this on my machine. Looks good to me. Tested on ubuntu 20.04 browser google chrome. When I first visited the site the install icon was there on...

> > > Is it possible to use the existing submitty duck image in `site/public/img` and the favicon already there? Is there something specific about the new ones checked in?...

I have added few labels that display different information in different cases : When installed in chrome: ![image](https://user-images.githubusercontent.com/92226302/180604335-5e5e5233-cf10-4268-bbdf-52a61da24f9c.png) When not installed in chrome: ![image](https://user-images.githubusercontent.com/92226302/180604372-e7f3ea33-707a-4238-a996-b5ab1f34c2d6.png) When in other browsers: ![image](https://user-images.githubusercontent.com/92226302/180604382-288196c8-da9e-4fe8-b8ad-d90b825da16f.png) I...

> > Regarding the SVG part, I guess it might create a problem to use it in android/ios (it was stated in Lighthouse documentation) but if it works then we...

It's fine, You may leave the developer section for now and start working on the rest of the section. Also, the documentation has a separate [repo](https://github.com/Submitty/submitty.github.io). If you have any...

Sure, let me know how you want to proceed and in what way I could help or if there is something u are stuck with. [Refer Developer Docs](https://submitty.org/developer/getting_started/index )

May be setting up the developer environment (Vagrant machine) will give you more idea about the thing, try to start with that