Submitty icon indicating copy to clipboard operation
Submitty copied to clipboard

[Bugfix:InstructorUI] Correction of Tags

Open immortalcodes opened this issue 2 years ago • 3 comments

What is the current behaviour?

Implements #7819 : Anchor tags were being used instead of button tags by relying on onclick event which created confusions in interpretation by screen readers and different browsers.

What is the new behavior?

All the instances of anchor tag which used onclick event have been updated with button tag in the entire codebase.

immortalcodes avatar May 18 '22 18:05 immortalcodes

Codecov Report

Merging #7906 (18171d4) into main (42e957c) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #7906   +/-   ##
=========================================
  Coverage     21.99%   21.99%           
  Complexity     7697     7697           
=========================================
  Files           207      207           
  Lines         25125    25125           
  Branches         64       64           
=========================================
  Hits           5525     5525           
  Misses        19538    19538           
  Partials         62       62           
Flag Coverage Δ
autograder 20.28% <ø> (ø)
js 30.32% <ø> (ø)
migrator 99.20% <ø> (ø)
php 20.12% <ø> (ø)
python_submitty_utils 71.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar May 18 '22 18:05 codecov[bot]

@shailpatels , what could I do to correct the checks.

immortalcodes avatar May 19 '22 17:05 immortalcodes

@immortalcodes It looks like an end to end test is consistently failing with the pull request test which usually means there's an issue when this branch gets merged into master. I would try to run the course materials cypress tests locally and see how they behave - maybe update with master to see if there are any issues locally.

Here are the docs to setup and run https://submitty.org/developer/testing/cypress

You can also click on the "details" on the right of each test to see the output and see what specifically is causing the issue

shailpatels avatar May 20 '22 16:05 shailpatels

Closing this inactive PR. If you wish to continue work on this issue, consider making a PR of smaller scope that is thoroughly tested so as to not break any existing site functionality.

skara9 avatar May 25 '23 22:05 skara9