Ivan Mirić

Results 171 comments of Ivan Mirić

There are samples for `about:blank` though: ``` {"type":"Point","data":{"time":"2022-06-07T17:58:23.714853023+02:00","value":0.031,"tags":{"group":"","scenario":"default","url":"about:blank"}},"metric":"browser_dom_content_loaded"} {"type":"Point","data":{"time":"2022-06-07T17:58:23.714869485+02:00","value":0.272,"tags":{"group":"","scenario":"default","url":"about:blank"}},"metric":"browser_loaded"} {"type":"Point","data":{"time":"2022-06-07T17:58:23.72161283+02:00","value":0.027,"tags":{"group":"","scenario":"default","url":"about:blank"}},"metric":"browser_dom_content_loaded"} ``` It could be that some are missed, but given that that's the first loaded page and that we have...

@inancgumus Which PR/commit fixed this? The PRs in the description don't seem to address it.

Are we even certain what needs to be done here? The comment linked in the description raises some questions, but the issue should describe what we want to refactor. Let's...

So, good news, sorta :sweat_smile: This issue is caused by the classic `click`/`waitForNavigation` race condition, which was difficult to fix until our recent async API changes. To illustrate the behavior...

I haven't seen this error since #499 and the recent race fixes were merged, so closing this. :crossed_fingers:

Nice catch! It doesn't seem related to `Locator`, but to `ElementHandle`: https://github.com/grafana/xk6-browser/blob/dbede120c63df43995813a847a25b0e66e289592/common/element_handle.go#L242-L244 It should call `Mouse.dblClick()` :smile:

This seems like a more general problem with selecting elements under a shadow DOM. If you notice, `input#horns` is under a `#shadow-root` element. In DevTools you can't select it with...

This might have also been fixed by #535, since we now ensure to call `dataDir.Cleanup()` after the process exits cleanly. I haven't noticed it in Cloud test runs at least....

I haven't seen this recently, so closing.

Are you using a custom `user-data-dir`? This issue was about the error happening during regular execution, not the scenario you're describing. It's probably a good thing that it fails in...