Ivan Mirić

Results 171 comments of Ivan Mirić

Ah, I suppose this is a duplicate of #107, just with a different API. We should ensure they both expose the same implementation.

Hey, thanks for looking into this! I completely missed that this caching would ensure it's only sent once. I also confirmed it with a packet capture, where only the first...

Given the backwards incompatible change of the second point, let's wait until at least the end of next cycle to do this. There's no rush to upgrade and we don't...

Once we do this we should test the full release CI workflow and fix any problems, since [the k6 team recently had issues with the v0.39.0 release because of this...

I think this is now fixed after #535 and can be closed, right? @grafana/k6browserdev

Thanks for the suggestion. As mentioned on Slack, we think it's a good idea, we just need to flesh out some details. Here are my notes from Slack: CDP has...

@ankur22 If we implement `Page.metrics()` like Puppeteer has, the script can get the value of `JSHeapUsedSize` and emit a custom metric sample any time it's needed. This would track JS...

Thanks for the nice sequence diagram :blush::thumbsup: I think your design looks good at a glance. It's difficult to analyze without seeing some PoC code, but here are some initial...

> Yes, good point. I didn't add that in the diagram, but well aware of it. I've added a TODO in my branch so that I don't forgot though. :thumbsup:...

@robingustafsson Why is this tagged with `needs async`? Isn't it essentially just another event we wait synchronously for? We also need this functionality for #253, which is another API for...