Ivan Mirić
Ivan Mirić
@satriaadhii That's a similar test to the [`fillform.js` example](https://github.com/grafana/xk6-browser/blob/990a95c07929f81109b3214590b0fb16f70396e3/examples/fillform.js). Notice that the example uses `page.waitForNavigation()` instead of `page.waitForLoadState('networkidle')` because there is a race condition that might trigger where the `networkidle`...
A similar issue was [reported on the forum](https://community.k6.io/t/error-when-doing-browser-close-on-windows/3637) by a Windows user: ``` ERRO[0002] err:read tcp 127.0.0.1:59516->127.0.0.1:59515: wsarecv: An existing connection was forcibly closed by the remote host. category="Connection:handleIOError" elapsed="0...
This error is more visible if running more than 1 iteration, e.g.: ``` XK6_BROWSER_LOG=info XK6_HEADLESS=1 xk6 run -u 1 -i 10 examples/fillform.js ``` We're prioritizing this issue higher, and will...
Hey everyone, apologies for the delay with this issue, but it should be fixed on the `main` branch now. You can test it out by compiling a custom binary with:...
Another issue is that wrong or missing comments on exported declarations aren't being checked. See https://github.com/grafana/xk6-browser/pull/65#discussion_r743603800. So it seems that `go vet` isn't setup properly. Though we might want to...
I think we should look into why `go vet` isn't working properly.
I would classify `go vet` under "linter issues", since we don't run it directly, but via `golangci-lint`. Actually, I'm not sure the missing comments check was done by `go vet`,...
So #216 adds the missing linters, so we now get errors on missing/wrong comments via `revive`. Considering that without `--new-from-rev` there are 1298 issues with that configuration, do we want...
I don't think I fixed any of them without `--new-from-rev`. The fixes in #216 were all with `--new-from-rev`.
Something we just noticed in #252 is that at least `tparallel` is not being triggered when `t.Parallel()` is missing. Running `golangci-lint run --out-format=tab --new-from-rev=main ./...` shows 0 errors after removing...