Terry Kim comments

Results 101 comments of


                                            Terry Kim

[Gold Standard] Initial Code showing Hyperspace Indexes with a sample query

Can you check the test failures?

[Gold Standard] Initial Code showing Hyperspace Indexes with a sample query

One way is to diff the file and attach it to the PR?

[Gold Standard] Initial Code showing Hyperspace Indexes with a sample query

> I added files for without hyperspace enabled and also with the diffs. Please let me know if we intend to keep them in the final version or is it...

Add warning log - newly created Hyperspace context for different Spark Session

Could you update the PR description as it seems out of date? Basically, we are preventing hyperspace context from being re-created in certain scenarios, and making sure too many contexts...

[FEATURE REQUEST]: Hyperspace indexing on s3 based data.

@nikhilsimha Could you share how you constructed the `DataFrame` that you passed to `createIndex`?

[FEATURE REQUEST]: Hyperspace indexing on s3 based data.

Oh, you cannot have a filter in the dataframe from which you are trying to create an index. You should be able to create an index if `leftDf` is simply...

[FEATURE REQUEST]: Hyperspace indexing on s3 based data.

I don't think this is s3 related issue. As long as you create an index from a relation (no filter, etc.), it should work. Please let me know if you...

[FEATURE REQUEST]: Hyperspace indexing on s3 based data.

@ashutosh-hs Hyperspace doesn't officially support Spark 3 yet (#85). Do you see the same error in Spark 2.4? In any case, could you run `df.explain` and copy/paste the output here?...

Use indexes subdirectory for custom index system path

I guess the only concern I have is the breaking change as you pointed out. @rapoth?

Cannot run Spark 3 tests in IntelliJ IDEA

Thanks @andrei-ionescu for reporting this. @clee704 Could you take a look when you get a chance? It's crucial to get this running in IntelliJ since most of us use it...