hyperspace icon indicating copy to clipboard operation
hyperspace copied to clipboard

[Gold Standard] Initial Code showing Hyperspace Indexes with a sample query

Open apoorvedave1 opened this issue 4 years ago • 7 comments

What is the context for this pull request?

Gold Standard: Hyperspace code for creation of index metadata files and its use in Plan Stability test Suite.

  • Parent Issue: #334
  • Dependencies: #377
  • Dependent PRs: #386

What changes were proposed in this pull request?

In this PR: TPCDSHyperspace suite extends PlanStabilitySuite

  • Ability to define indexes : indexname, tablename, indexed cols(comma-separated), included cols(comma-separated)
  • Create index metadata files (metadata files are enough for generating query plans)
  • A simple query with join between two tables on a key
  • Approved plans (golden files) for the simple query

Does this PR introduce any user-facing change?

No

How was this patch tested?

Unit tests

apoorvedave1 avatar Mar 18 '21 18:03 apoorvedave1

Should we just have code update + one query example?

imback82 avatar Mar 18 '21 19:03 imback82

Should we just have code update + one query example?

@imback82 removed dependencies coming from the dependency PR. now this one contains only relevant files.

apoorvedave1 avatar Mar 18 '21 20:03 apoorvedave1

Can you check the test failures?

imback82 avatar Mar 19 '21 04:03 imback82

Can you check the test failures?

@imback82 thank you, I also cleaned up some other parts of the code. Please take a look.

apoorvedave1 avatar Mar 19 '21 18:03 apoorvedave1

One way is to diff the file and attach it to the PR?

imback82 avatar Mar 19 '21 22:03 imback82

One way is to diff the file and attach it to the PR?

I added files for without hyperspace enabled and also with the diffs. Please let me know if we intend to keep them in the final version or is it just for the sake of validation in the PR.?

apoorvedave1 avatar Mar 22 '21 18:03 apoorvedave1

I added files for without hyperspace enabled and also with the diffs. Please let me know if we intend to keep them in the final version or is it just for the sake of validation in the PR.?

This is just for the PR.

imback82 avatar Mar 23 '21 00:03 imback82