Terry Kim
Terry Kim
> 2\. Redefine the helper constructor (the `IndexLogEntry.apply`) and add an extra boolean parameter called `addVersion`. This seems reasonable to me since the intention should be clear from the caller...
@apoorvedave1 Could you do this? 1. Take resource files from OSS Spark and create a PR, and we will just merge quickly. 2. Rebase this PR. The reason is I...
> This is an initial setup with spark only (non-hyperspace) version of gold standard. Please refer parent proposal for more details Could you update this PR description as well? Not...
Are the test failures related to the cross join?
> Measured `executePlan` performance using TPCH dataset: Could you explain the importance of this benchmark? (I wasn't sure what to get out of this benchmark.)
I just checked the code, and you meant to measure re-executing the updated plan?
Here is what I suggest on how to write the benchmark paragraph (my thoughts in parenthesis): This PR introduces triggering `SparkSession.executePlan` inside `JoinIndexRule` to check if unnecessary shuffle is introduced...
@sezruby Can you check if this issue can be closed?
Thanks @andrei-ionescu for the info. I just took a quick look at it and it doesn't seem straightforward to plug it in (@clee704 / @sezruby please correct me if I...
Should we just have code update + one query example?