Sivaramakrishnan Vaidyanathan
Sivaramakrishnan Vaidyanathan
@nytai All checks have passed. Is it good to merge this ?
@rusackas Hoping you can take another look at the changes we've so far and comment on whether anything else is needed before this pr can be merged and issue resolved?
> The tooltip looks strangely high up, otherwise we're looking good, and thanks for the touchup! I'll try to find time in a bit to pull your branch and see...
> > The tooltip looks strangely high up, otherwise we're looking good, and thanks for the touchup! I'll try to find time in a bit to pull your branch and...
> OK, I think we're good to go otherwise... I'll await feedback before unilaterally merging. I think Truthfulness outweighs Consitency, which outweighs pretty much any other random change ;) @rusackas...
I followed all your steps and just before running `superset db upgrade`, set the `SECRET_KEY` and it worked just fine for me.
> So, as it turns out, in my supersset_config with a SQLAlchemy path configured it will fail. If I comment out the following in my config file it works fine....
@rusackas I've never contributed to OSS. I would like to take a stab at this one if nobody is actively working on it.
@rusackas I've raised PR - https://github.com/apache/superset/pull/28349. I see that 2 checks have passed but another 18 are waiting to be reported, hope this is ok. Hope to get a review...
> Looks like the PR is super close... I just had a question about he renaming of the Name filter to Search, since it introduces an inconsistency between list views...