apache
fix: Add back description column to saved queries #12431
Fixes https://github.com/apache/superset/issues/12431
Add back Description column
Add tooltip for search box
@rusackas Hoping you can take another look at the changes we've so far and comment on whether anything else is needed before this pr can be merged and issue resolved?
The tooltip looks strangely high up, otherwise we're looking good, and thanks for the touchup! I'll try to find time in a bit to pull your branch and see about using the tooltip component's props to align it, but I'm working on something else at the moment.
The tooltip looks strangely high up, otherwise we're looking good, and thanks for the touchup! I'll try to find time in a bit to pull your branch and see about using the tooltip component's props to align it, but I'm working on something else at the moment.
ack. I'll try to align it as well later in the evening.
The tooltip looks strangely high up, otherwise we're looking good, and thanks for the touchup! I'll try to find time in a bit to pull your branch and see about using the tooltip component's props to align it, but I'm working on something else at the moment.
ack. I'll try to align it as well later in the evening.
@rusackas Hope it looks better now.
@villebro worked on making all lists consistent (using Name) and may have some input here.
OK, I think we're good to go otherwise... I'll await feedback before unilaterally merging. I think Truthfulness outweighs Consitency, which outweighs pretty much any other random change ;)
OK, I think we're good to go otherwise... I'll await feedback before unilaterally merging. I think Truthfulness outweighs Consitency, which outweighs pretty much any other random change ;)
@rusackas Just following up to find out if we need anything else in this PR or if we are good to merge this change.
I'm not sure if there's a better way to fix an icon's size/position like this. This feels wrong, but it works without tweaking the underlying component. Still curious if @geido has any better ideas, or if @villebro has any arguments against doing this. Meanwhile, I think it LGTM and will merge if we don't hear back soon.
Can we merge this change today or should we wait till next week ?