Ilkka Seppälä comments

Results 718 comments of


                                            Ilkka Seppälä

Fix high severity issues reported by SonarCloud

Most of the high severity issues fixed by @k1w1dev, but still 18 remain. See https://sonarcloud.io/project/issues?impactSeverities=HIGH&resolved=false&id=iluwatar_java-design-patterns

Fix sonar issues

Looks good! Thank you for the contribution 🎉 @all-contributors please add @k1w1dev for code

Refactored changes for seperated-interface

Seems to contain changes for several patterns. Could you make a separe PR for each?

#2546 - Remove code repetition from flyweight README

Looks good! Thank you for the contribution 🎉 @all-contributors please add @samuelpsouza for docs

Pattern pages should link to the code in Github

Great @biswajitbhunia123, I'll assign you. Looking forward to the PR 💪

Doesn't work with springboot project

@klingen-m feel free to submit pull request, no write access needed

Change visibility of the constructor of DomainMapper

Please rebase this branch on top of `master` to utilise the latest changes.

Update to JUnit 5

Yes, sorry for the late reply @Harsh4902

Feature/fuction composition

Looks good! Thank you for the contribution 🎉 @all-contributors please add @Adelechka for code

fix: Refactor Layered Architecture pattern #2936

Let me know when it's ready for review