java-design-patterns icon indicating copy to clipboard operation
java-design-patterns copied to clipboard
verified publisher icon iluwatar

Refactored changes for seperated-interface

Open drishtii7 opened this issue 1 year ago • 3 comments

What problem does this PR solve?

For the method getTaxPercentage introduced in the DomesticTaxCalculator and ForeignTaxCalculator classes, and it's common to both classes. I have pull this method up to a superclass named AbstractTaxCalculator.

drishtii7 avatar Mar 31 '24 23:03 drishtii7

Seems to contain changes for several patterns. Could you make a separe PR for each?

iluwatar avatar Apr 01 '24 07:04 iluwatar

hey @drishtii7, The code style does not follow the google style that project use.

See: https://github.com/iluwatar/java-design-patterns/wiki/12.-IDE-instructions

You can run the checkstyle checks using IDE plugin or using the command line (mvn validate).

MaverickWingman avatar Apr 03 '24 20:04 MaverickWingman

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar May 04 '24 06:05 stale[bot]

Closed due to inactivity. Thank you for your contributions.

stale[bot] avatar Jun 18 '24 08:06 stale[bot]