Andrey Loskutov

Results 414 comments of Andrey Loskutov

@basilevs : could you provide a fix?

There is one test failing: ``` java.lang.AssertionError: SetData callback count not in range: 10001 at org.junit.Assert.fail(Assert.java:89) at org.junit.Assert.assertTrue(Assert.java:42) at org.eclipse.swt.tests.junit.Test_org_eclipse_swt_widgets_Tree.test_Virtual(Test_org_eclipse_swt_widgets_Tree.java:966) ``` I haven't checked if this is related to this...

@zkxvh : this branch has merge conflicts with master. Could you please rebase the changes on latest master state?

Also note, you are not supposed to check-in so files!

Are you thinking about something [like this](https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/184897/4/bundles/org.eclipse.swt/Eclipse+SWT/gtk/org/eclipse/swt/widgets/Table.java) before this loop in `Table.remove()`: https://github.com/eclipse-platform/eclipse.platform.swt/blob/0f47f6b701c87581621bca610d6358587900a9a3/bundles/org.eclipse.swt/Eclipse%20SWT/gtk/org/eclipse/swt/widgets/Table.java#L2712

Sure, feel free to look at it later. I will close my PR then. Thanks for pointer.

> could this be a JDT issue? I'm not aware about recent related JDT changes, also if IDE doesn't show them it looks like maven/tycho build problem? Could be some...

Here is direct link to report https://ci.eclipse.org/releng/job/eclipse.platform.swt/job/master/1079/eclipse/new/ where `Unnecessary @SuppressWarnings("restriction")` is reported for `/org.eclipse.swt.tools.spies/src/org/eclipse/swt/tools/internal/Sleak.java` > I'm not aware about recent related JDT changes, also if IDE doesn't show them it...

> Okay this fails now, what makes me even wonder how it is supposed to work that SWT requires platform at all? SWT doesn't require platform.ui, but Sleak (from org.eclipse.swt.tools.spies)...

> Btw. I now also see similar new warnings in platform.ui: > https://ci.eclipse.org/platform/job/eclipse.platform.ui/job/master/947/eclipse/new/ > Although these are new unused-code warnings regarding record components, so actually a different type of warning....