Andrey Loskutov

I believe first option sounds better, but I'm fine with any option, do whatever you prefer.

> My commit used the correct, approved email address, but I've created the pull request with my GitHub account. Don't know why eclipsefdn/eca complains. This commit should only have committers...

I plan to analyze the bytecode and touch affected bundles in ~ 1 hour from now (I urgently need a lunch). If someone wants, feel free to create PR's for...

Created following PR's: - [x] https://github.com/eclipse-jdt/eclipse.jdt.debug/pull/679 ``` eclipse.jdt.debug/org.eclipse.jdt.debug.ui/ eclipse.jdt.debug/org.eclipse.jdt.debug/ ``` - [x] https://github.com/eclipse-jdt/eclipse.jdt.ui/pull/2178 ``` eclipse.jdt.ui/org.eclipse.jdt.core.manipulation/ eclipse.jdt.ui/org.eclipse.jdt.ui.tests/ ``` - [x] https://github.com/eclipse-pde/eclipse.pde/pull/1728 ``` eclipse.pde/apitools/org.eclipse.pde.api.tools/ eclipse.pde/ds/org.eclipse.pde.ds.annotations/ eclipse.pde/ui/org.eclipse.pde.bnd.ui/ eclipse.pde/ui/org.eclipse.pde.core/ eclipse.pde/ui/org.eclipse.pde.genericeditor.extension/ eclipse.pde/ui/org.eclipse.pde.ui/ ``` - [x]...

> > ./eclipse.platform/runtime/tests/org.eclipse.e4.core.tests/target/artifactcomparison/no-classifier/org/eclipse/e4/core/internal/tests/di/InjectBridgeTest$Concrete.class-build > > ./eclipse.platform/runtime/tests/org.eclipse.e4.core.tests/target/artifactcomparison/no-classifier/org/eclipse/e4/core/internal/tests/nls/BundleMessagesRegistry.class-build > > [@jarthana](https://github.com/jarthana) - Can you validate these two files ? These changes are originating from your PR. No indication of trouble per my...

Since we only have one questionable change I assume we are fine to trigger new SDK build to see also test results with changed code. I've triggered https://ci.eclipse.org/releng/job/Builds/job/I-build-4.36/82/

> > This seem to be strange. It **loses** generic signature on record constructor? > > Yes, it is a bug! Issue raised [eclipse-jdt/eclipse.jdt.core#3951](https://github.com/eclipse-jdt/eclipse.jdt.core/issues/3951) - Fix is straightforward and underway...

https://download.eclipse.org/eclipse/downloads/drops4/I20250423-0800/ is available. The fix for https://github.com/eclipse-jdt/eclipse.jdt.core/issues/3951 would require https://github.com/eclipse-platform/eclipse.platform/pull/1834 to be merged for the same SDK build, otherwise we will have another comparator error on `org.eclipse.e4.core.di` bundle due `org.eclipse.e4.core.internal.di.AnnotationLookup.AnnotationProxy`...

> This seems to be plagued by infra issues :-( Which from many ? :-( * https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/5921 * https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/5892 * https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/5893

Both https://github.com/eclipse-jdt/eclipse.jdt.core/issues/3951 and https://github.com/eclipse-platform/eclipse.platform/pull/1834 are merged.