Andrey Loskutov

Results 414 comments of Andrey Loskutov

I wrote already: > Are you sure the Error log view is not opened in a different perspective? In that case closing it would not have expected effect, since it...

> I agree with @laeubi that this is surprising. Not for me. > Would be nice to change the current behavior of the error view, especially if even our (hard-core)...

> independent from the preference setting. But that would break what the preference was supposed to do (again, since ever). It says "Activate on new events" (so far it was...

May be this PR should have a test case?

> Isn't that going to be confusing or at least inconvenient for users? I'm thinking about products like ours where the editors tab position is important because we have lot...

Please use github pull request for patches. We can't accept patches "as text" due legal (IP) reasons.

Looks like OOM's are happening now later, **after** UITestsuite is executed: ``` Tests run: 1659, Failures: 7, Errors: 44, Skipped: 196 Exception: java.lang.OutOfMemoryError thrown from the UncaughtExceptionHandler in thread "Active...

Last build had no OOM's but multiple test fails due https://github.com/eclipse-platform/eclipse.platform/issues/1592, see https://ci.eclipse.org/platform/job/eclipse.platform.ui/job/PR-2433/2/#showFailuresLink **I guess** the OOM problem could be related / fixed by https://github.com/eclipse-jdt/eclipse.jdt.core/pull/3126, I saw https://github.com/eclipse-jdt/eclipse.jdt.core/commit/9c11818e53959318b2914d52978dd7729bd7df88 broke lot...

> But that could be just coincidence, I will retrigger tests once again. See https://ci.eclipse.org/platform/job/eclipse.platform.ui/job/PR-2433/3/ No OOMs, but lot of test fails related to https://github.com/eclipse-platform/eclipse.platform/issues/1592.

Hmm, interestingly there **are** OOM errors on https://github.com/eclipse-platform/eclipse.platform.ui/pull/2438.