Ilona Tomkowicz

Results 118 comments of Ilona Tomkowicz

Note for the future: unsubscribing from the handlers did not fully fix the issue, the last 2 hits are on PRs created after the fix was merged.

Following the stack: https://github.com/dotnet/runtime/blob/84b7c2f15ceec32e66b46231614dfcb3e334c6fd/src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs#L548 https://github.com/xunit/xunit/blob/6bfa188331f6d4ed6e877ab6da5e7b2725ccd721/src/xunit.v3.core/Framework/TestOutputHelper.cs#L45 We might be trying to `WriteLine` in a try-catch, after xunit threw an exception. I'm gonna wrap `protected readonly ITestOutputHelper _testOutput;` in a custom class,...

Sample log: ``` Wasm.Build.Tests.SatelliteAssembliesTests.ResourcesFromMainAssembly(buildArgs: BuildArgs { ProjectName = placeholder, Config = Release, AOT = False, ProjectFileContents = placeholder, ExtraBuildArgs = }, nativeRelink: True, argCulture: "es-ES", host: V8, id: "iomynnb2_4h0") [STARTING]...

The last 2 hits are on PRs that had the https://github.com/dotnet/runtime/pull/108319 change. It's still unfixed

> [@ilonatommy](https://github.com/ilonatommy) this looks like it is showing up a lot in release/9.0 If it's much more than on net10 then let's backport https://github.com/dotnet/runtime/pull/108319, https://github.com/dotnet/runtime/pull/108387, https://github.com/dotnet/runtime/pull/105561 Edit: the unsubscribing is...

There are no hits on net10 because we stopped running tests with self-created process in the refactoring PR: https://github.com/dotnet/runtime/pull/109069 and we are not keeping handlers for logging manually but we...

The only hits after the fix are net8 where we did not backport and they are very rare.

This is catching all the logs with `WasmTestOnChrome` scenario that fail from different reasons, we are **always** logging in the first lines: ``` Console log: 'WasmTestOnChrome-ST-System.Net.Http.Functional.Tests' from job 45dc3733-eef6-44d4-b816-c51f097137d6 (ubuntu.2204.amd64.open.rt)...

Not only `System.Net.Http.Functional.Tests`, e.g. [System.Runtime.InteropServices](https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-105299-merge-db91a9546a5b4b30b5/WasmTestOnChrome-MT-System.Runtime.InteropServices.JavaScript.Tests/1/console.f3074913.log?helixlogtype=result). I'm updating the pattern