Ilona Tomkowicz

Results 118 comments of Ilona Tomkowicz

Some of these APIs got already covered: ```diff +Microsoft.AspNetCore.Components.NavigationManager.NotFound() -> void ``` in https://github.com/dotnet/aspnetcore/issues/61133 and as a result of that review, we added: ```diff +Microsoft.AspNetCore.Components.Routing.NotFoundEventArgs +Microsoft.AspNetCore.Components.Routing.NotFoundEventArgs.NotFoundEventArgs() -> void ``` in...

Remaining API reviews from the list: - https://github.com/dotnet/aspnetcore/issues/62408 - https://github.com/dotnet/aspnetcore/issues/62409 - https://github.com/dotnet/aspnetcore/issues/62415 - https://github.com/dotnet/aspnetcore/issues/62412

It looks that delay increase mitigated the issue. In case of more problems, consider investigating the Windows image details we're using on CI: https://github.com/microsoft/playwright/issues/32897. The last weeks failures are on...

It hasn't been seen for months, we can consider https://github.com/dotnet/runtime/pull/108474 was the fix.

Tests that use reflection fail: ``` at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args) at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr) ``` ``` at System.Object.InvokeStub_ResourceReaderTests.ReadResource(Object , Span`1 ) at System.Reflection.MethodBaseInvoker.InvokeWithOneArg(Object obj, BindingFlags invokeAttr, Binder binder,...

> Maybe on browser the env variable `MONO_AOT_MODE` is never set ? The test is run with `/p:EnableAggressiveTrimming=true /p:BuildAOTTestsOnHelix=true /p:RunAOTCompilation=false`. It's true that `MONO_AOT_MODE` is never set, because `ENABLE_AOT` is...

About this part: > > Maybe on browser the env variable `MONO_AOT_MODE` is never set ? > It's true that `MONO_AOT_MODE` is never set, because `ENABLE_AOT` is not defined. I...

Browser does not support diagnostics, so in the current state it's expected to trim https://github.com/dotnet/runtime/blob/8e8143ec8754773fb2b34e5165ca92c2fdeb98ac/src/libraries/System.Net.Http/src/System/Net/Http/HttpTelemetry.cs#L12 This can be enabled once we have EP working on WASM browser.

The error can indicate a mismatch of chromedriver and chrome version. Failing tests are on Linux (we're not testing Windows at all). We are using chromedriver: `84.0.4147.0`, chrome: `Chromium 84.0.4147.0`...

Yes, but the original reason was to fix https://github.com/dotnet/runtime/issues/107771 by allowing default chromium in WasmBuildTests. If we do it, we would like to keep browser versions in line across our...