BenchmarkDotNet icon indicating copy to clipboard operation
BenchmarkDotNet copied to clipboard
verified publisher icon dotnet

[wasm] Rename module file to .mjs

Open mkhamoyan opened this issue 1 year ago • 4 comments

Rename test-main.js to test-main.mjs

mkhamoyan avatar Jul 24 '24 08:07 mkhamoyan

/azp run runtime-wasm

ilonatommy avatar Jul 24 '24 12:07 ilonatommy

Commenter does not have sufficient privileges for PR 2597 in repo dotnet/BenchmarkDotNet

azure-pipelines[bot] avatar Jul 24 '24 12:07 azure-pipelines[bot]

/azp run runtime-wasm

This should not be required, as the WASM test added by @caaavik-msft in https://github.com/dotnet/BenchmarkDotNet/pull/2532 should be just always executed.

adamsitnik avatar Jul 29 '24 17:07 adamsitnik

May I ask why is this file being renamed again? What do we get from it?

The test-main.js file was updated to require the --module flag. Renaming the file to .mjs helps clarify that it is a JavaScript module.

mkhamoyan avatar Jul 30 '24 09:07 mkhamoyan

cc @radical Looks similar to #2345.

timcassell avatar Sep 08 '24 04:09 timcassell

Closing as we decided not to rename the file

mkhamoyan avatar Sep 09 '24 07:09 mkhamoyan