Ilia Ross

Results 664 comments of Ilia Ross

I must say that we're facing here both a very interesting and complex issue. Let's just make things as complex as possible from the start - let's set `tempdir` to...

Yes it works. Although, if `$subdir` somehow gets both the space and wildcard char in its name, it would fail the same way. However, I assume the second part is...

I forgot that we also have to do it for SSL certificate paths. ![image](https://user-images.githubusercontent.com/4426533/151723108-87c5c6d1-fc08-403e-b48d-9dc1eff3e7d7.png)

That is fixed here https://github.com/virtualmin/virtualmin-gpl/commit/90e8924856b7e92cd28749989649955f70177983, check it out please, Jamie. This also has to be fix, probably on Webmin side somewhere: ![image](https://user-images.githubusercontent.com/4426533/151724037-bec21c1c-6a71-4a44-bb06-5901ad55e189.png)

Ah, okay. Also fixed. Please check this one too - https://github.com/webmin/webmin/commit/a8084803db51c789290801f3d200e2e444f8665c. ![image](https://user-images.githubusercontent.com/4426533/151724258-11dfd725-8473-4697-8aa9-ce0eff0ecff9.png)

There is more to do though: ![image](https://user-images.githubusercontent.com/4426533/151777998-ad1614e5-a234-4b34-a6a0-2cee80203e56.png) Please check these patches - https://github.com/webmin/webmin/commit/292db2b760be77ff614597c9338d4157209cc847

It depends on the browser. The error message may be shown. Redirect may have a delay. Try it like 10 times in a row to see what I mean.

Yeah, I thought of that too. Although, I don't see how it could fail.. Nevertheless, maybe we should make it even more user friendly, and first print: ``` Redirecting to...

Close but it wanted you to click the link. And as you mentioned the host detection wasn't great. I think we can just leave it as it is now on...

Jamie, I have changed it a little more. It will print a nice message and redirect automatically: ..and if a user doesn't have Javascirpt enabled, it will show a message...