Ilia Ross

Results 664 comments of Ilia Ross

Fonts' contrast must fit accessibility standards: ![image](https://user-images.githubusercontent.com/4426533/149788780-740b0106-ecfb-4826-994f-6eaf0b20e50c.png) For some color palettes it's a bit less though but still close, and well visible? Is this how you see it? ![image](https://user-images.githubusercontent.com/4426533/149788472-c2d053d3-11b2-4a6a-8062-c624ddaf70ff.png) >...

Oh, wow. This is an interesting issue. I have been looking around it for hours trying to figure out the solution. I think I [fixed it locally](https://github.com/webmin/webmin/commit/3c687b46be545e7489bfe5848c960cca57529ee9) but it's not...

I am endlessly confused! It appears that the fix I just made above is the only possible right solution? The actual breakage was happening at the line I fixed (the...

Yes, I didn't modify it. Yes, I quoted it in the caller.

Should we not allow a user to have **`tempdir`** with spaces? I know it's super rare but still.

Okay, great. I don't mind as longs as it works safe and fine.. I think we need to audit other modules, using regex search or something to try to locate...

> Best practice in Webmin is to always use quotameta on paths, as failing to do so can cause security issues if the path is in any way controlled by...

Agreed! Thank you for pointing this out in the first place.

> I think we need to audit other modules, using regex search or something to try to locate familiar case senarious. For example, when **`tempdir`** set with spaces, in Virtualmin...

Thanks. But script installation still fails when `tmpdir` contains spaces :slightly_smiling_face: ![image](https://user-images.githubusercontent.com/4426533/151681983-a2b81ae4-5241-4f13-819d-d32504511048.png)