Brian

Results 26 comments of Brian

Sounds good, I'll take a look into it when I get the chance

Thanks for the feedback! I'll make those changes

> Do you mind to add tests for the new methods ? Yup, I missed it earlier. They've been added in https://github.com/gazebosim/sdformat/pull/1088/commits/a26db0ea77a6a4b184458eebaae6048363c9dfbe

> to improve test coverage, let's add these new fields to the `sensors.sdf` test file and add corresponding test expectations to `link_dom.cc` @scpeters I've done so in https://github.com/gazebosim/sdformat/pull/1088/commits/47bb73a8e2b68a597c3c4ea941f886b71aa9e6de.

https://github.com/kristijanhusak/orgmode.nvim/issues/64#issuecomment-896468813 Seems like `coc.nvim`'s workspace isn't picking up on `v:lua` variables?

This should be resolved as of https://github.com/ros-perception/image_common/pull/246 for rolling. @mkhansenbot if this addresses the problem feel free to close this issue.

Right, I definitely wasn't thinking when I put this PR together :sweat_smile:. Will update this PR to support multiple parameters & `param load --atomic`

`ros2 param set` with multiple parameters PR opened: https://github.com/ros2/ros2cli/pull/728 This PR is based off that PR (https://github.com/ros2/ros2cli/pull/728) and now implements `--atomic` for `set` and `load` verbs. Diff: https://github.com/ros2/ros2cli/compare/brianc/multiple_param_set...brianc/atomic_parameter_set

@crystaldust Are you still working on this? If not I'd be take over and help push this PR through.

+1 to be able to widen the branch name selector to fit long branch names on github web and github desktop. This is particularly aggravating when using github on any...