Ignasi Marimon-Clos

Results 261 comments of Ignasi Marimon-Clos

I think the problem is on : https://github.com/akka/alpakka-kafka/blob/4f7760f2ec10a3abd7ca049667dd85b5c0b408e3/tests/src/test/scala/akka/kafka/internal/CommittingWithMockSpec.scala#L216-L222 It's a block that attempts to wait until all the commits have been submitted by counting how many callbacks were registered. The...

Fixed (?) in #1047. We can reopen if the issue is not solved completely.

Did a first hack in #1260 (which hides the unnecessary complexity from the rendered HTML). The long-term solution should be: - create a new proto file - remove the use...

about status codes. See: * https://developers.google.com/maps-booking/reference/grpc-api/status_codes and https://github.com/grpc/grpc-java/blob/e60a179772f29554b69b2f8d7678dc18979fe7fc/core/src/main/java/io/grpc/Status.java#L69-L68 (or https://godoc.org/google.golang.org/grpc/codes) * https://github.com/grpc/grpc/blob/master/doc/statuscodes.md and * https://github.com/grpc/grpc/blob/master/doc/http-grpc-status-mapping.md

Related to https://github.com/lightbend/akka-grpc/issues/76#issuecomment-372709790

I think the problem with `CallOptions` is that it's an all-or-nothing object that configures a bunch of stuff: ```java deadline = other.deadline; authority = other.authority; credentials = other.credentials; executor =...

There are three levels of commitment here: - `Status`/`StatusRuntimeException`/`StatusException` (*): this is small enough that we could trivially do ourselves. If we don't do it ourselves we expose users to...

Maybe this can wait until https://github.com/playframework/play-grpc/pull/345 has landed.

> See ignasi35/[email protected] (bumps Akka to 2.6) Ths issue there is not a real issue. The test was not properly ported: the test requires 2 different `Materializer` instances and the...

Some mental notes: A gRPC client has a `Channel` instance connecting the client to a single remote host and that `Channel` is shared across several calls. Lagom's `CircuitBreakingServiceLocator` offers a...