akka-grpc icon indicating copy to clipboard operation
akka-grpc copied to clipboard

remove timestamp from walkthrough example

Open raboof opened this issue 4 years ago • 1 comments

We recently made it easier to pull in the standard dependencies, and added a timestamp to the 'helloworld' proto to test that.

Unfortunately, that was the .proto we also use for the walkthrough in the documentation (https://doc.akka.io/docs/akka-grpc/snapshot/client/walkthrough.html). I think for the walkthrough we should keep things as simple as possible, so make sure we use a proto without external types.

raboof avatar Jan 07 '21 11:01 raboof

Did a first hack in #1260 (which hides the unnecessary complexity from the rendered HTML).

The long-term solution should be:

  • create a new proto file
  • remove the use of external dependencies from ./plugin-tester-scala/src/main/protobuf/helloworld.proto (loosing the scala version of the "use external dependencies test")
  • ... (?)

ignasi35 avatar Feb 08 '21 14:02 ignasi35